Private category comments exposed via email

Indeed it looks like it. The test does not check that the user has been participating in the discussion explicitly (either by personal mention or invitation) nor that – which I guess is our case for the leak – the topic under consideration is in a category restricted to a group (i.e. where everyone does not have see permission). So I guess the test should return false if the user is staged but not in current participants list and not in any of the authorized groups. It might be enough to:

return false if is_staged? && category.read_restricted?
1 Like