Found while building 2.2.0.beta10~git21.f7b7bc8abe files with x bit without a shebang line. bin/docker/README.md lib/javascripts/moment_locale/*.js script/import_scripts/json_generic.rb vendor/assets/javascripts/sweetalert.js probably just chmod -x all the files zero byte files app/assets/javascripts/admin/templates/components/flag-counts.hbs app/assets/javascripts/admin/templates/components/permalinks-list.hbs app/assets/javascripts/discourse/templates/modal/merge-topic.hbs app/assets/javascripts/discourse/templates/modal/split-topic.hbs app/views/list/top.erb app/views/static/password_reset.html.erb app/views/static/signup.html.erb public/javascripts/ace/mode-text.js spec/fixtures/plugins/my_plugin/nested/plugin.rb are all of them expected?

What RPM package? Discourse isn’t distributed in RPM.

I build one myself. and our package check found those issues. Thought I would clarify them with upstream.

None of the listed files should have the x bit set. As for the empty files, if there are indeed useful, then we should add a comment explaining why/where they’re used.

Yes I see no reasons to act on this before release. Im assigning this to me, to try to remove these files after release.

A few small issue found during RPM package build

Development

codinghorror (Jeff Atwood) January 31, 2019, 12:10am 4

Does any of this need fixing for the release @j.jaffeux?

Topic		Replies	Views
Discourse build is broken due to removed file? Development	11	2132	October 16, 2017
Ubuntu development install: Permission denied @ apply2files Self-hosting	1	3209	July 15, 2019
Failed to bootstrap while rebuilding a contrainer Self-hosting	6	1383	October 10, 2016
Minor spelling issue in installation script Self-hosting	2	729	February 6, 2018
Mini_racer breaks build on latest-release Product Support unsupported-install	2	1470	April 29, 2019

A few small issue found during RPM package build

Related topics