Trouble with `discourse remap` remapping `topic_links url`

pfaffman · February 28, 2019, 3:47pm

Hey @Falco, would truncating the URL in line 120 fix this?

change it to

    uri = UrlHelper.relaxed_parse(u.url[0..self.max_url_length])

github.com/discourse/discourse

app/models/topic_link.rb

main


      
            "COALESCE(t.archetype, 'regular') <> :archetype",
            archetype: Archetype.private_message,
          )
          
          if guardian.authenticated?
            builder.left_join(
              "topic_users AS tu ON (t.id = tu.topic_id AND tu.user_id = #{guardian.user.id.to_i})",
            )
            builder.where(
              "COALESCE(tu.notification_level,1) > :muted",
              muted: TopicUser.notification_levels[:muted],
            )
          end
          
          # not certain if pluck is right, cause it may interfere with caching
          builder.where("l.post_id in (:post_ids)", post_ids: posts.map(&:id))
          builder.secure_category(guardian.secure_category_ids)
          
          result = {}
          builder.query.each do |l|
            result[l.post_id] ||= []

EDIT: well, on my first attempt, this yielded

Remapping topic_links url
Error: ERROR:  duplicate key value violates unique constraint "unique_post_links"
DETAIL:  Key (topic_id, post_id, url)=(19484, 61049, https://staging.community.rstudio.com/t/birds-of-a-feather-bof-at-rstudio-conf-2019l/19328) already exists.
The remap has only been partially applied due to the error above. Please re-run the script again.

So short of a database migration to make the URL longer. . . maybe add another rescue on duplicate URLs and let them pass? So also add a

    rescue PG::UniqueViolation

that does nothing?

Topic		Replies	Views
PG::StringDataRightTruncation (ERROR: value too long for type character varying(500) ) Bug	10	4168	June 4, 2021
`discourse remap` failed Self-hosting	4	845	March 19, 2020
Error running remap after changing site url Self-hosting sql-query , domains , postgres	12	500	July 3, 2026
Remap failure when changing discourse domain Self-hosting	1	333	May 2, 2024
Restored Site - URLS need to be corrected, any ideas? Product Support	11	452	April 11, 2025

Trouble with `discourse remap` remapping `topic_links url`

Related topics