Disable service worker initializer

sam · April 30, 2019, 4:09am

Correction, we only de-register stuff that we know is ours:

app/assets/javascripts/discourse/initializers/register-service-worker.js.es6

2863abefd


      
          if (
            registration.active &&
            !registration.active.scriptURL.includes(
              Discourse.ServiceWorkerURL
            )
          ) {
            registration.unregister();
          }

One spinner is that we de-register apple cause it is buggy at the moment:

github.com/discourse/discourse

app/assets/javascripts/discourse/initializers/register-service-worker.js.es6

2863abefd


      
          const isApple = !!navigator.platform.match(/(Mac|iPhone|iPod|iPad)/i);

As to using scope here, I think it makes sense to make the change to Discourse provided scope is well supported.

Topic		Replies	Views
Discourse Development: Failed to register/update a ServiceWorker Product Support	6	1337	June 11, 2018
Exploring ServiceWorkers for Discourse Feature	24	9700	February 22, 2018
Android+Chrome not registering service workers Bug	6	3199	April 9, 2018
Adding service workers for third party services Development	0	624	October 16, 2018
Discourse as a Progressive Web App Feature	21	5438	January 30, 2017

Disable service worker initializer

Related topics