The review content was basically that the current way is so completely wrong that it needs to be rebuilt completely from scratch and in a different way; that the attempt to fix it in the way it was previously written is not OK. I am not up for that, so I really think that migrate_from_s3 should be removed entirely and migrate_to_s3 marked that it’s a one-way door that you better really mean to stick with forever. Right now having migrate_from_s3 in the source at all is a data integrity fault in Discourse.
I didn’t get timely review while I was working on the migration process, and now that I have long since migrated (with some broken results, like some broken avatars), I am without a meaningful test bed. I have zero confidence that I would do it right, so I have bowed out of this fight. It’s up to the next poor schmuck who thought it would be a good idea to put images in some S3-alike object storage service to resolve the problem. Sorry!