This is my route code: import { defaultHomepage } from "discourse/lib/utilities"; export default Discourse.Route.extend({ beforeModel(transition) { if (!Discourse.User.current()) { $.cookie("destination_url", window.location.href); return this.replaceWith("login"); } this.replaceWith(`/${defaultHomepage()}`).then(e => { Ember.run.next(() => { this.controllerFor("new-proof").send("openModal", transition.to.queryParams); }); }); }, }); The redirection to the login page works well, but after login, I get redirected to the correct controller but without the query parameters I had in the original request. Is there a way around this that doesn’t involve using custom local storage entries/cookies? Am I doing something wrong?

I still don’t know how to preserve query params, but I have solved my own issue by using url params instead of query params (so the route is now /keybase-proofs/new-proof/:username/:kb_username/:sig_hash).

Do we want URL params? That seems highly unorthodox.

I assumed it was the right way to do it since the query params get lost in the transition. Perhaps I am doing something wrong with destination_url or the redirection to login?

[תמונה] emanuele: The redirection to the login page works well, but after login, I get redirected to the correct controller but without the query parameters I had in the original request. I think it’s a bug in the core. I see a similar fix for SSO by @sam – FIX: stop removing query params from destination url in sso · discourse/discourse@0b334cd · GitHub I will investigate and push a fix.

Note that redirect with query params survives login flow for http://localhost:9292/new-topic?title=beta. Relevant code can be found here: app/assets/javascripts/discourse/routes/new-topic.js.es6 102be5a9e // User is not logged in $.cookie("destination_url", window.location.href); this.replaceWith("login"); @emanuele I will need more details. What login method are you using (email/password, social, sso, etc)? Can you provide a sample URL with query param? Is your plugin live? Can I test it on my local instance? Feel free to PM me above details.

Hi :slight_smile: I am using email/password http://localhost:9292/keybase-proofs/new-proof?kb_username=etamponi&username=emanuele.tamponi&sig_hash=puppa&kb_ua=foo The plugin code is at: GitHub - etamponi/discourse-keybase-proofs-plugin: Discourse Plugin for Keybase Proofs · GitHub To test it, replace the value of the username query param with your username. The route code is in routes/new-proof.js.es6 and it looks basically the same as the code you posted.

Looking at: app/controllers/static_controller.rb 863d8014d elsif redirect_location.present? && !redirect_location.match(login_path) begin forum_uri = URI(Discourse.base_url) uri = URI(redirect_location) if uri.path.present? && (uri.host.blank? || uri.host == forum_uri.host) && uri.path !~ /\./ destination = uri.path destination = "#{uri.path}?#{uri.query}" if uri.path =~ /new-topic/ || uri.path =~ /new-message/ || uri.path =~ /user-api-key/ end rescue URI::Error # Do nothing if the URI is invalid end end redirect_to destination end FAVICON ||= -"favicon" It seems like we preserve query params for a few pre-defined paths and this pattern started with this commit (not sure why I did that… :confused:). @sam should we start supporting query params for all the paths? I don’t see any security implication by allowing query params on random path.

[תמונה] techAPJ: should we start supporting query params for all the paths? I don’t see any security implication by allowing query params on random path. As long as this is carefully reviewed I think it is fine to extend support here.

This issue is now fixed via: https://github.com/discourse/discourse/commit/1708be4f27216392d429442524916bf8b6175443

Redirect after login loses query params

מפתח

sam (Sam Saffron) 1 ביולי,‏ 2019,‏ 12:44am 12

As long as this is carefully reviewed I think it is fine to extend support here.

נושא		תגובות	צפיות
Does discourse has return_path or return_link I can leverage to redirect to previous link after log in complete? Product Support login	2	160	22 באוגוסט,‏ 2026
GTM parameters are not preserved, or passed to GTM Product Support	3	420	9 במאי,‏ 2024
Users not redirected to original page upon successful login Product Support	2	217	14 באוגוסט,‏ 2025
Url to pass back after SSO to redirect back to previous url/topic SSO	0	1624	31 בינואר,‏ 2017
Redirect after login one like logout redirect Feature	6	6459	10 בינואר,‏ 2015

Redirect after login loses query params

נושאים קשורים