Should I keep my theme on GitHub or not?

Absolutely, it is best practice to keep any sizeable theme on a Git repo. It makes tracking changes easier, using theme creator CLI the workflows are delightful so its even easier to hack on.