We figured it out. If we navigate to /admin/plugins.json we could see that the plugin id which is usually populated by the plugin name was not set.
It turns out those fields are populated by having a section of comments in the plugin.rb file… so the fix was adding this in:
# frozen_string_literal: true
# name: example
# about: example about
# version: 1.0
# authors: example
# url: example
I feel like if you are going to require comments in a file this should be well documented somewhere.. so I’ll leave this solution here.