He there! In my installation of Discourse 2.5.0.beta1 there is not working highlighting searched keywords in search results if search was done in other than english. Is it a bug or a feature?) Thanks [Screenshot_20200228_162254]

Created a new PR with the fix https://github.com/discourse/discourse/pull/9163

We only highlight complete words. This looks like a partial word.

Hi! Expecting that the founded keyword would be highlighted like so: [Screenshot_20200301_160048]

sorry, not in this case: [Screenshot_20200301_160600]

@vinothkannans can you have a quick look at: app/assets/javascripts/discourse/lib/highlight-text.js.es6 4635be10c words = words.map(w => w.replace(/^"(.*)"$/, "$1")); const highlightOpts = { wordsOnly: true }; if (!opts.defaultClassName) highlightOpts.className = CLASS_NAME; $elem.highlight(words, highlightOpts); @smith can you make a post here with the exact Greek word? (I think this is Greek) this could be a bug in our highlighting Javascript library.

This is Cyrillic, based on Greek tho, here is some example: Ибо угодно Святому Духу и нам не возлагать на вас никакого бремени более, кроме сего необходимого: воздерживаться от идоложертвенного и крови, и удавленины, и блуда, и не делать другим того, чего себе не хотите. Соблюдая сие, хорошо сделаете. Будьте здравы.

vendor/assets/javascripts/highlight.js 7b194743d if (settings.wordsOnly) { pattern = "\\b" + pattern + "\\b"; } The issue is in the jQuery Highlight plugin. To highlight the words it’s using the word boundary \b regex which is not supported in Unicode characters. https://medium.com/@shiba1014/regex-word-boundaries-with-unicode-207794f6e7ed (?<=[\s,.:;"']|^)UNICODE_WORD(?=[\s,.:;"']|$) It looks like a possible solution :thinking:

I think @gerhard dealt with this particular issue with unicode usernames (at least I vaguely recall) Super happy to see a fix here, but we got to be ultra careful that whatever regex we choose does not have pathologically bad performance in certain cases where text is long or particularly bad. Also I think in Chinese we don’t even care about word boundaries?

Search results are not highlighted in some languages

Product Support

smith (Smith John) March 1, 2020, 1:05pm 4

Hi! Expecting that the founded keyword would be highlighted like so:

Topic		Replies	Views
Discobot "capybara" search Bug	8	1693	March 26, 2019
`undefined` as a search term is getting lost and not highlighted in the search results Bug	3	954	November 13, 2017
Searching with quoted term doesn't highlight the whole term Bug	8	1944	July 20, 2017
Word disappears when searched and in <details><summary<kbd><b> Bug	8	2511	March 2, 2015
Highlight to Search Theme component search	10	345	April 13, 2026

Search results are not highlighted in some languages

Related topics