Edits not being stored in user_actions table

sam · April 22, 2020, 10:42pm

Is this an instance hosted by us or a self hosted instance?

Our notification fires here:

app/services/post_action_notifier.rb

776caa24c


      
            if user_ids.present?
              DB.after_commit do
                Jobs.enqueue(:notify_post_revision,
                  user_ids: user_ids,
                  post_revision_id: post_revision.id
                )
              end
            end
          end
          
          def self.after_post_unhide(post, flaggers)

The condition is quite strong:

github.com/discourse/discourse

app/services/post_action_notifier.rb

776caa24c


      
          if post_revision.user_id != post.user_id
            user_ids << post.user_id
          end

Notification is created here:

github.com/discourse/discourse

app/jobs/regular/notify_post_revision.rb

776caa24c


      
          ActiveRecord::Base.transaction do
            User.where(id: args[:user_ids]).find_each do |user|
              next if post_revision.hidden && !user.staff?
          
              PostActionNotifier.alerter.create_notification(
                user,
                Notification.types[:edited],
                post_revision.post,
                display_username: post_revision.user.username,
                acting_user_id: post_revision&.user_id,
                revision_number: post_revision.number
              )
            end
          end

The thing that could break this is

Sidekiq being backed up with jobs or paused
Super rare condition of terminating the job half way through notifying

Topic		Replies	Views
Editing posts cause notification Product Support	23	3767	May 24, 2021
Watching / Tracking / Notifications for post edits for Moderators Feature	21	4647	February 3, 2020
Free to edit post at any time Feature	33	15931	May 22, 2023
Wiki post edits not shown in user's activity Feature	1	511	October 8, 2019
New way to track edits on wiki posts? Product Support wiki-posts	17	743	October 4, 2025

Edits not being stored in user_actions table

Related topics