On previous versions, a landing page was shown on which the “login” button appeared. Clicking this buttons showed the saml login page. Personally, I really liked this behavior. With the current version 2.4.2 this isn’t possible any more as the saml login page is shown immediately. Is it configurable?

[image] sbernhard: “security” (I know, its not really a big blocker). Cheap hacking scripts on the main URL (without the landing page) would fail hopefully as its required to press the login button first. The automatic redirect should not introduce any security vulnerabilities. If you are aware of an exploit, please let us know via our disclosure program: discourse/docs/SECURITY.md at main · discourse/discourse · GitHub [image] sbernhard: Would you accept a PR which adds a configuration option (default: new behavior)? I don’t think we want to add more noise to the settings until we have some more users requesting this change. You could override this in a plugin by patching this method: app/controllers/application_controller.rb main end def mini_profiler_enabled? return false unless MINI_PROFILER_CLASS return true if Rails.env.development? return true if guardian.is_developer? if auth = cookies.encrypted[:_mp_auth] user_id = auth[:user_id] issued_at = auth[:issued_at] if issued_at && issued_at > MINI_PROFILER_AUTH_COOKIE_EXPIRES_IN.ago.to_i user = User.find_by(id: user_id) return true if user && Guardian.new(user).is_developer? end end false So I think you would want to simplify the function right down to def redirect_to_login dont_cache_page cookies[:destination_url] = destination_url redirect_to path("/login") end

I am not following, you mean we showed a modal that had a single button “Login with SAML” ?

No. in a previous version (I guess it was 2.3.6) it was like this: [login] After clicking on “Anmelden” the SAML login window appeared. If I enable “local logins” the landing page with the login button appears again but I don’t want to have local login and therefore I need to disable it.

Can someone help me? maybe @eviltrout ?

I certainly didn’t change this on purpose. If you could help us track down when it changed that would be helpful as we could look into the context. It’s possible it changed for security reasons.

This was a long requested improvement to make omniauth behave like real SSO, when the number of omniauth login methods is only one. [image] SSO vs Oauth2 difference? SSO This is now implemented: If there is only one external authenticator enabled and local logins are disabled and the site requires login, then users will be directed straight to the external authentication page. This exactly matches the implementation of our Discourse-native SSO. I can’t think of a reason why anyone wouldn’t want this, so this is now the default behaviour. cc @consideRatio @Joralf

How can I help? one hint: if you enable “local login”, the “Landing page together with the login button” is shown.

If you really want the confirmation page, you can link the user to /login (rather than the homepage). That will not trigger the login automatically. But note this is not really supported, it is just a quirk of the implementation and may change at any time.

New behavior is better and consistent with SSO login. If a message is needed before login it can be implemented in the Identity Provider.

ah, good to know. I know of 2 reasons: show a very nice landing page with some basic information instead of that “boring” login window “security” (I know, its not really a big blocker). Cheap hacking scripts on the main URL (without the landing page) would fail hopefully as its required to press the login button first. Is it possible to configure this behavior?

[image] sbernhard: Is it possible to configure this behavior? You are going to need to hire a dev here to build a plugin to change this. As it stands this is the first complaint I have heard about the new system in months.

Landing page on saml login

Product Support

sbernhard (Bernhard Suttner) April 30, 2020, 6:41am 12

I’m a dev (see my changes in discourse_saml)

Would you accept a PR which adds a configuration option (default: new behavior)?

Topic		Replies	Views
Change login button action Product Support	4	1522	March 16, 2018
Simple plugin to create landing page for SSO not working anymore Development	0	466	May 31, 2022
Disable local login with SAML Product Support	15	1260	August 5, 2022
Is there any way to bypass the login prompt entirely when using SAML? SSO	0	730	August 2, 2021
Prevent redirecting to SSO login and open discourse login SSO	5	759	September 13, 2024

Landing page on saml login

Related topics