PullHotlinkedImages does not replace images again after post is edited

Perfect, thanks for the detailed summary! I think the problem is here:

I managed to produce a failing test case for this. It seems we only do the URL replacement when the image is first downloaded. If we have already downloaded the image once, it won’t be replaced again.

This is a failing test which demonstrates the issue

https://github.com/davidtaylorhq/discourse/blob/27ccf99d162005f82bf4d4e69f860cf78affcfcb/spec/jobs/pull_hotlinked_images_spec.rb#L63-L80

I will add it to my list to fix. I should be able to get to it in the next few weeks.

7 likes