Why does the API often fail to create thumbnails although big enough images are downloaded? Example, if you paste this in an opening post… [תמונה] Legal experts are freaking out about Bill Barr’s actions to help Trump win -... "The attorney general is a threat to American citizens having free and fair access to the vote" Est. reading time: 2 minutes This onebox downloads a large enough image with dimensions of 690 x 465: [image] Still, no thumbnail created for the topic.

Yes, thanks @merefield, but we just use @david’s theme component, not the TLP TC. But I will probably use your eval to patch core if we don’t get some movement or an option provided by the @team on this issue.

The above render is from the TLP TC, but yes, I use a back-end plugin (the theme ‘side car’) to modify the Ruby :).https://github.com/merefield/discourse-topic-previews/tree/theme_sidecar I appreciate that may not be an option if hosted.

[תמונה] Terrapop: it’s currently not on the table [תמונה] Terrapop: we don’t get some movement or an option provided by the @team This is totally on the table, that’s why it is tagged #pr-welcome :smiley: Check this post for a starting point for implementation.

@merefield Kindly can you do the PR? Unfortunately, I am completely new to Ruby. Or how is the process for a PR?

@david I would definitely be delighted to be able to remove this override from the plugins and agree a core solution would be best.

@Terrapop here are the Contributing to Discourse development I would be a more immediate assistant on this but rammed with client work atm.

Understood. I just have a simple docker dev environment for developing some simple plugins and core patches, yet. Will wait until we have someone to look at this and probably patch via your eval in the meantime.

A proper job here is not an immaterial project, because you need to modify test cases, and work across the two components (discourse and discourse one-box). But definitely worth doing! Ruby is nothing to fear after Ember btw :wink:

Yes, but this is defo out of my current scope and abilities unfortunately.

As a work around I often manually copy and paste the image into a whisper, then select the thumbnail from that. Automatic would be nicer, perhaps with a config item to give domains where thumbnails shouldn’t be taken from one boxes (i.e. to cover the github case).

שימוש בתמונות onebox לתמונות ממוזערות של נושאים

מפתח

Terrapop 11 בפברואר,‏ 2021,‏ 6:45pm 21

Woohooo finally! Now I can disable our plugin that has overridden the core. Thank you @david

נושא		תגובות	צפיות
Thumbnails are missing for our external embeds when using topic-thumbnails Development pr-welcome	10	1239	31 במרץ,‏ 2023
Problems with thumbnails from Soundcloud and YouTube oneboxes Product Support	11	2147	3 ביוני,‏ 2020
Oneboxing uses full size thumbnail images UX	10	1455	27 במרץ,‏ 2019
Issue with Onebox and Youtube Bug onebox	10	1370	20 באוגוסט,‏ 2019
Add Onebox integration; show thumbnail with topic-thumbnails plugin Development	1	639	31 במרץ,‏ 2023

שימוש בתמונות onebox לתמונות ממוזערות של נושאים

נושאים קשורים