Uploaded profile pic keeps getting over-ridden by gravatar (DiscourseConnect)

david · March 30, 2021, 9:33am

This does sound like a bug. The logic we have here is

app/models/discourse_single_sign_on.rb

eb25d3a95


      
          avatar_missing = user.uploaded_avatar_id.nil? || !Upload.exists?(user.uploaded_avatar_id)
          
          if (avatar_missing || avatar_force_update || SiteSetting.discourse_connect_overrides_avatar) && avatar_url.present?
            avatar_changed = sso_record.external_avatar_url != avatar_url
          
            if avatar_force_update || avatar_changed || avatar_missing
              Jobs.enqueue(:download_avatar_from_url, url: avatar_url, user_id: user.id, override_gravatar: SiteSetting.discourse_connect_overrides_avatar)
            end
          end

Assuming discourse connect overrides avatar is off, that means we should only be changing the avatar when both of these are true:

The user has not chosen an avatar in Discourse
The identity provider is sending an avatar in the DiscourseConnect payload

It sounds like something might be going wrong here. @Soohian any chance you could share the URL to your site via PM?

Topic		Replies	Views
Custom Avatar not persisting between logins Product Support	8	201	March 12, 2025
Sso overrides avatar WordPress	4	2091	February 2, 2017
Unable to change profile pic due to SSO override SSO	9	3532	October 16, 2017
SSO Failing to Override Avatar SSO	1	874	May 9, 2022
SSO - custom picture not getting updated again once it is updated initially Product Support rest-api	7	371	January 1, 2025

Uploaded profile pic keeps getting over-ridden by gravatar (DiscourseConnect)

Related topics