I think we landed on “I am uncomfortable of the place we ended up, cause it is a support nightmare and is never going away :)”.
I feel like if a site is a spam vector, they should be allowed to say “make all my emails canonical” I don’t care about the downsides.
Meaning these 2 emails both have the canonical of samsam@somewhere.com
sam.sam@somewhere.com
samsam+11@somewhere.com
If sam.sam@somewhere.com registered, samsam+11@somewhere.com can no longer register.
That was my original fix, which I ended up reverting (though it special cased for Google - which in retrospect was not harsh enough)
I feel we should just put this one behind us by adding a new site setting for:
“OMG I am a giant spam vector, put on mega tinfoil mode”
Regarding the bug, stuff can sneak in now easily if you wait to block. It is currently a 100% reactive process.
Meaning this works just fine (feel free to test in console @markersocial ):
./launcher enter app
rails c
ScreenedEmail.block('examplemailaddress@gmail.com')
ScreenedEmail.should_block?('e.x.a.m.pl.e.m.ai.lad.dre.ss@gmail.com')
# true
The problem is:
# 100s of accounts created
ScreenedEmail.block('examplemailaddress@gmail.com')
# 100s of accounts are still there