Hi, We have customized the default discourse site at discourse version between (2.3 - 2.6). In the mentioned versions, we have applied custom CSS to hide the reply button in topic page footer buttons based on the value of element property aria-label. After upgrading the discourse version to 2.8.0.…

Although the reply button is not coming from this, it’s a standalone {{d-button}} https://github.com/discourse/discourse/blob/main/app/assets/javascripts/discourse/app/templates/components/topic-footer-buttons.hbs#L59 The change is coming from this commit: https://github.com/discourse/discourse/c…

You are correct, it appears to be missing. Looks like the value of aria-label is calculated here: discourse/register-topic-footer-button.js at 362c47ce6a87783808cb4417912a75250f003bf8 · discourse/discourse (github.com) Looks like there was work on this only 6 days ago?: DEV: adds a new topic foot…

[image] j.jaffeux: styling based on aria label is not a good practice Is that because the value depends on locale?

Yes exactly, that’s very prone to change too :+1:

Discourse version upgrade cause data loss (aria-label) on DOM elements properties

Product Support

j.jaffeux (Joffrey Jaffeux) November 18, 2021, 10:37am 6

Yes exactly, that’s very prone to change too

Topic		Replies	Views
Accessibility software and discourse Feature	51	12359	May 9, 2015
Jump to reply arrow seems broken after updating to latest beta of Discourse Bug	3	716	August 30, 2021
Big White Gap at Footer after updating to latest Discourse version Product Support	8	2513	March 4, 2015
Text missing in Discourse Docs top menu button Bug docs	3	614	June 28, 2022
Accessibility: New Topic/Reply form not accessible to screen reader Bug pr-welcome	14	2350	February 16, 2023

Discourse version upgrade cause data loss (aria-label) on DOM elements properties

Related topics