Protecting members from accidentally sharing their email address in a PM

Product Support
5

So I was investigating an issue where reply-by-mail PM’s were leaking email addresses and disabling “always show trimmed content” did not work.

The three dots that show the rest of the email when clicked are shown when:

  • it’s a PM, or
  • when “always show trimmed content” is set (which apparently means “show trimmed content in non-PM posts as well”)

code:

# only add elided part in messages
if options[:elided].present? && (SiteSetting.always_show_trimmed_content || is_private_message)
  options[:raw] << Email::Receiver.elided_html(options[:elided])
  options[:elided] = ""
end

My question is:

  • what is the reasoning behind this being “always on” for PM’s? @zogstrip do you know?
  • and would it be a possibility to change this so admins would have the option to never show the trimmed content (and deny access to the “raw” email by clicking the envelope)? It’s pretty easy from a technical point of view so I’m not sure why this is not the case already.