Sam went so far as to refer to the change as being surprisingly complex. I don’t doubt him.
The aggregate effort of the original change and plus this is obviously going to be greater than had this been considered from the outset. We established at the time that while one community found the current default objectionable, there were several communities which hinged on this behavior. For example, for the union who abandoned their Discourse-based skills training site didn’t take the decision lightly, but it was but impractical for them to continue once trainees invited by staff were lost in the general approval pool.
If the issue here was a lack of explicit understanding, then there probably needs to be an intermediary step between must approve users and the invite modal which offers the option for staff invites to bypass approval, otherwise the original complaint which led to this change could still arise.
So more like:
- When
must approve usersadmin setting enabled and a newstaff invites bypass approvalis changed from its default ofnever: - If
alwaysthen the old behavior would take effect - If
optionalthen display the switch in the modal to give the option of bypassing subsequent approval
Without the intermediary admins aren’t fully aware of the implications of must approve, and a little granularity will solve the other issue when forgetting to use the toggle