Expired events with end times are being removed from upcoming-events even with setting set to -1

Benjamin_D · July 27, 2022, 10:01am

If you’re referring to the setting delete expired event posts after, I think it prevents the deletion of the post, but not the display of the event, plus I think the term event here is misleading, it’s in the calendar section so I think it means more “date related thing” than “event in the rsvp-possible sense”.
that’s a calendar-event, not an event-event

event-events are meant to be displayed in /upcoming-events hence nothing in the past…

github.com/discourse/discourse-calendar

lib/discourse_post_event/event_finder.rb

e544ef61f


      
          
          if params[:expired]
            # The second part below makes the query ignore events that have non-expired event-dates
            events = events
              .where("dcped.finished_at IS NOT NULL AND (dcped.ends_at IS NOT NULL AND dcped.ends_at < ?)", Time.now)
              .where("discourse_post_event_events.id NOT IN (SELECT DISTINCT event_id FROM discourse_calendar_post_event_dates WHERE event_id = discourse_post_event_events.id AND finished_at IS NULL)")
          else
            events = events.where("dcped.finished_at IS NULL AND (dcped.ends_at IS NULL OR dcped.ends_at > ?)", Time.now)
          end

There is a PR about that actually: FEATURE: Show all events in past (add deleted_at in discourse_calendar_post_event_dates) + add show_past_event in settings by ledadu · Pull Request #199 · discourse/discourse-calendar · GitHub

Topic		Replies	Views
Past events keep getting deleted Product Support events	3	581	November 10, 2023
Why do past events disappear on the calendar, but others stay visible? Product Support events	2	215	December 6, 2024
Display old Events on the 'Upcoming Events' page Feature events , completed	8	1355	January 9, 2024
Can you diable the removal of past Events? Product Support events	1	262	July 29, 2023
Ability to make topics in an event category hidden after the end date has passed Feature events	0	347	October 27, 2023

Expired events with end times are being removed from upcoming-events even with setting set to -1

Related topics