I naively attempted to create a plugin (which I’ve never done, other than running through the plugin tutorial some years ago) to override the limits set in the DataExplorer module, however I’m not getting it to work. Am I on the right track or is this a completely wrong approach? plugin.rb master # name: x-discourse-data-explorer-max # about: Plugin to override the data explorer plugin max settings # version: 0.0.2 # authors: Thomas K. Running # url: https://github.com/tkrunning/x-discourse-data-explorer-max enabled_site_setting :data_explorer_max_enabled module ::DataExplorer # QUERY_RESULT_DEFAULT_LIMIT = 1 # QUERY_RESULT_MAX_LIMIT = 1000000 QUERY_RESULT_MAX_LIMIT = 1000000000 end Note: I am setting the QUERY_RESULT_DEFAULT_LIMIT to 1 to make it easier to test if the custom limits are taking effect.

I recommend against a plugin here. Instead submit a PR to add a GlobalSetting (which is backed by environment)

Apparently this hasn’t been a high priority for ranyone in the past 2 years, but I needed this today and solved it by editing the file by hand inside the container. A workaround is something like the below in app.yml: after_bundle_exec: - replace: filename: "/var/www/discourse/plugins/discourse-data-explorer/plugin.rb" from: /QUERY_RESULT_MAX_LIMIT = 10_000/ to: QUERY_RESULT_MAX_LIMIT = 100_000 But it looks like the PR would be something like adding this to plugin.rb: GlobalSetting.add_default(:query_result_max_limit, 10000) and then changing the above module to something like QUERY_RESULT_MAX_LIMIT = GlobalSetting.query_result_max_limit || 10_000 Is that all it would take?

Close… I would stop using the constant and instead use GlobalSetting.query_result_max_limit everywhere, you are already configuring a default, why configure it twice.

[image] Sam Saffron: you are already configuring a default, why configure it twice. But there needs to be a default if they don’t set the GlobalSetting?

[image] Sam Saffron: You set it, in plugin.rb OHHHHHH. I guess “add_default” does, in fact, add a default. :person_shrugging: Oops. [image] Jay Pfaffman: GlobalSetting.add_default(:query_result_max_limit, 10000) So add the default GlobalSetting and replace all of the references to the old constant with the GlobalSetting. Got it. I’ll see what I can do.

Creating a plugin to override QUERY_RESULT_MAX_LIMIT

Development

sam (Sam Saffron) December 5, 2024, 9:20pm 6

You set it, in plugin.rb

Topic		Replies	Views
How to change the response default_limit in data explorer? Development data-explorer	14	2059	November 9, 2023
How to export more than the 10,000 limit? Development data-explorer	3	1119	September 14, 2022
How to bump 10k records csv export limit in Data Explorer? Development data-explorer	6	1447	November 30, 2021
Has something changed in the data explorer? Can't get query via API Product Support data-explorer , rest-api	8	300	March 11, 2026
I want to increase post words limit on digital ocean based discourse instance Product Support	4	153	July 6, 2024

Creating a plugin to override QUERY_RESULT_MAX_LIMIT

Related topics