Google Maps embeded links sometimes work, sometimes don't (onebox 404)

Falco · February 21, 2023, 10:02pm

Looks like our regex for zoom level doesn’t allow dots here:

lib/onebox/engine/google_maps_onebox.rb

main


      
              break if type != :standard
              sleep 0.1
            end
          end
          
          case type
          when :standard
            # Fallback for map URLs that don't resolve into an easily embeddable old-style URI
            # Roadmaps use a "z" zoomlevel, satellite maps use "m" the horizontal width in meters
            # TODO: tilted satellite maps using "a,y,t"
            match = @url.match(/@(?<lon>[\d.-]+),(?<lat>[\d.-]+),(?<zoom>\d+)(\.\d+)?(?<mz>[mz])/)
            raise "unexpected standard url #{@url}" unless match
            zoom = match[:mz] == "z" ? match[:zoom] : Math.log2(57280048.0 / match[:zoom].to_f).round
            location = "#{match[:lon]},#{match[:lat]}"
            url = "https://maps.google.com/maps?ll=#{location}&z=#{zoom}&output=embed&dg=ntvb"
            url += "&q=#{$1}" if match = @url.match(%r{/place/([^/\?]+)})
            url += "&cid=#{($1 + $2).to_i(16)}" if @url.match(/!3m1!1s0x(\h{16}):0x(\h{16})/)
            @url = url
            @placeholder =
              "https://maps.googleapis.com/maps/api/staticmap?maptype=roadmap&center=#{location}&zoom=#{zoom}&size=690x400&sensor=false"
          when :custom

Quite an easy fix.

Topic		Replies	Views
Google Maps Onebox Issue Product Support	4	2384	May 3, 2019
Google Maps onebox issues Bug	15	3901	January 1, 2016
Embedding google maps short urls is broken Feature	9	7152	March 22, 2015
Embedded google map stopped working Product Support	10	4904	September 30, 2020
Google maps link not embedding anymore Product Support	2	697	September 12, 2022

Google Maps embeded links sometimes work, sometimes don't (onebox 404)

Related topics