If I understand the comment by @Jagster correctly, he is not arguing against the use of share-alt for the external-link-plus-SM-share popup on desktop / OS share UI on mobile, but rather he saying that since it is a share functionality, using the external link icon wouldn’t cover the functionality entirely.
That’s my interpretation, I could be wrong