S3 uploads incompatible with server-side encryption

JammyDodger · July 7, 2023, 11:27am

I think this has now been merged.

github.com/discourse/discourse

FIX: don't use etags for post-upload verification (#21923)

main ← mpalmer:no-etag

merged 07:53AM - 07 Jul 23 UTC

mpalmer

+8 -15

They don't work for server-side encryption with customer keys, and so instead we… just use Content-MD5 to ensure there was no corruption in transit, which is the best we can do. See also: https://meta.discourse.org/t/s3-uploads-incompatible-with-server-side-encryption/266853 No tests were changed because, as far as I can tell, there are no tests for this area of the codebase.

Topic		Replies	Views
S3 uploads and Cache-Control Feature	1	1225	May 30, 2016
Restore process cancelled at migrating uploads to S3 step Product Support	48	3967	January 24, 2026
Images didn't load after configuring S3 uploads Product Support	4	949	August 27, 2021
Can't migrate uploads to S3 Product Support s3	8	446	June 12, 2025
Restore fails due to s3 migration failure Product Support	2	167	August 12, 2026

S3 uploads incompatible with server-side encryption

Related topics