Add PM for promotion to TL3 (to be consistent with TL1 and TL2)

JammyDodger · August 26, 2023, 6:55pm

I’ve just had a quick test with one of my test users and I think you do get another message on being ‘re-promoted’. I had them locked at TL0 for some time, and just unlocked them again and when the TL was re-evaluated I got the suite of them for both TL1 and TL2: (they’ve been all the trust levels before at some point)

Checking the code, it looks like it skips the PM if they already have the TL badge, and I think that’s recalculated daily - so if a Trust Level is lost&regained in the same day I think it would skip the PM (depending on how the time window of demotion and background job aligned).

github.com/discourse/discourse

spec/lib/promotion_spec.rb

aaf0b0f1c


      
          end
          it "sends promotion message by default" do
            SiteSetting.send_tl1_welcome_message = true
            @result = promotion.review
            expect(Jobs::SendSystemMessage.jobs.length).to eq(1)
            job = Jobs::SendSystemMessage.jobs[0]
            expect(job["args"][0]["user_id"]).to eq(user.id)
            expect(job["args"][0]["message_type"]).to eq("welcome_tl1_user")
          end
          
          it "does not not send when the user already has the tl1 badge when recalculating" do
            SiteSetting.send_tl1_welcome_message = true
            BadgeGranter.grant(Badge.find(1), user)
            stat = user.user_stat
            stat.topics_entered = SiteSetting.tl1_requires_topics_entered
            stat.posts_read_count = SiteSetting.tl1_requires_read_posts
            stat.time_read = SiteSetting.tl1_requires_time_spent_mins * 60
            Promotion.recalculate(user)
            expect(Jobs::SendSystemMessage.jobs.length).to eq(0)
          end

Though just to add as well, the Automation can also trigger on user demotion. So if you tailored the right message for your forum that handled each I think it would still be viable to send both each time the TL3 was gained and lost (which could support adding it to core).

Topic		Replies	Views
Send Promotion PMs Feature automation	40	6220	September 11, 2024
Customise text for TL3 promotion PM Product Support trust-levels	4	617	August 26, 2023
Send message when a user reaches tl2 Feature	4	846	March 6, 2020
Allow users to disable Trust Level Promotion message/notifications UX	25	1693	April 13, 2023
Create a public post to celebrate TL3 promotion Feature automation	0	189	March 5, 2023

Add PM for promotion to TL3 (to be consistent with TL1 and TL2)

Related topics