Ads on my forum dont always fill and sometimes Google isn’t able to find an ad atm, so it just shows blank. This is fine, but I believe the advertisement text and the white space taken during this scenario should be removed since it leads to some confusion (eg. people thinking the above post was a promoted advertisemnt) [image]

I figured it out!! It will keep the Advertisement text hidden by default, and only show it after confirming the ad is filled and displayed. This way I can ensure there is no confusion. If you want to enable this on your forum, take a look at the detailed tutorial I posted on my blog https://blog.codergautam.dev/how-to-hide-unfilled-advertisements-in-discourse-adplugin/ Edit: using revised version of working code after Firepup found a bug Hope this helps someone!

I am not sure about the white-space but I think this works for the text: [image] AdSense: Remove 'ADVERTISEMENT' text Support I’m sorry, I didn’t realize it couldn’t be empty. You can put some CSS in a theme component to hide it: .google-adsense-label { display: none; } should work.

I guess that is a workaround for now, but the text is now always hidden. I would prefer to have it when an ad is showing, hidden when it’s not. I will mess with the css and see if I can make a selector that runs when ads are empty.

I think it should be theoretically possible since google marks it with this property: [image]

Apparently google incorrectly fills out that field (Note the iframe): [Screenshot (15)]

And apparently you can’t just check for the iframe either, as sometimes it adds a practically empty iframe.

I can’t cause this anymore, must have been a one-off.

[image] Firepup Sixfifty: Apparently google incorrectly fills out that field No I tested it a lot, when its unfilled it still adds an iframe but keeps it empty. When its filled however the iframe is populated. It’s not a bug.

There was at least once I manually un-hid the AD, and there was actually an AD there, even though it was marked as unfiled. I couldn’t cause it again after that though.

Just in case you wouldn’t be aware of it, the CSS :has selector isn’t widely supported, notably Firefox: :has() CSS relational pseudo-class | Can I use... Support tables for HTML5,... "Can I use" provides up-to-date browser support tables for support of front-end web technologies on desktop and mobile web browsers.

Remove blank space and advertisement text on unfilled ad

Product Support

Canapin (Coin-coin le Canapin) October 2, 2023, 1:38pm 11

Just in case you wouldn’t be aware of it, the CSS :has selector isn’t widely supported, notably Firefox:

Topic		Replies	Views
Blank/Empty ads on Discourse Adsense Adplugin Product Support advertising	11	1531	May 26, 2023
AdSense: Remove 'ADVERTISEMENT' text Product Support	4	823	November 21, 2019
Adsense blank ads Product Support advertising	17	6658	January 20, 2020
A strange question about google ad display in my site Product Support advertising	5	1211	June 26, 2023
Extend and maintain theme-component related to Google Ads / Google Tag Manager \| Short-term work and long-term retainer Marketplace	0	325	May 18, 2024

Remove blank space and advertisement text on unfilled ad

Related topics