Problem is @ember/string is deprecated it appears after Ember 4.x? I can’t see this package in Ember 5.x … so this would just be a bandaid until Discourse rapidly moves into 5.x (which David alluded to here: Upgrading Discourse to Ember 4 - #14 by david) @David what’s the right call here - use native Javascript (like I have)?

Thanks for the report - we weren’t expecting the JQuery change to affect string prototype extensions, so we’re digging into that :eyes: [image] Robert: Problem is @ember/string is deprecated it appears after Ember 4.x? As I understand it, it’s just the prototype extensions that are deprecated. So doing something like "mystring".capitalize() will not be allowed. But you’ll still be able to do stuff like this: import { capitalize } from "@ember/string"; capitalize("mystring"); So, that’s what I’d recommend you do in the topic-list-previews component :ok_hand: (more before/after examples here)

No worries but was surprise to me too :sweat_smile:

I had a look through all-the-themes and all-the-plugins, and there are just a couple of public plugins which need fixing up. I made PRs here: (cc @merefield @angus) Remove use of Ember string prototype extensions by davidtaylorhq · Pull Request #35 · paviliondev/discourse-layouts · GitHub Remove use of Ember string prototype extensions by davidtaylorhq · Pull Request #7 · paviliondev/discourse-news · GitHub Godfrey did some digging for us into why the JQuery commit triggered this, and his findings are in this PR. So, it’s technically possible for us to restore this functionality, but it involves applying a patch to an upstream dependency which is not ideal. Given the complexity, and that we’d be removing them in a few months anyway, I think it makes sense to just double-down on the removal now. I’ve formalised that in this PR: https://github.com/discourse/discourse/pull/24110 Let us know if you have any questions/concerns

Removal of Ember string prototype extensions

Development

merefield (Robert) October 26, 2023, 10:12am 5

Thanks David. I agree with strategy. Kind of you to provide PRs.

Topic		Replies	Views
Upgrading Discourse to Ember 4 Development ember	19	3518	December 19, 2024
Preparing for Discourse's upgrade to Ember 5 Announcements	53	8879	April 8, 2024
Site broken due to ember 5 upgrade Development	15	989	March 1, 2024
New installs will default to Ember CLI builds in Production Announcements ember	36	4462	June 17, 2022
Conflict with Quantcast RGPD solution "choice" and ember.js Development	12	1911	December 15, 2020

Removal of Ember string prototype extensions

Related topics