My first run at this PR was pretty messy, I admit. I’ve since closed the initial PR, squashed commits and resubmitted. Is there a typical timeline for plugin PR review? Did I flub in not first asking for the functionality? It seemed like it ought to be pretty simple to do, so I thought I’d just “get 'er done!” Even a “thanks, no thanks” would be fine…

I’ve reopened this one as though this particular PR has been merged the general question of what to do to nudge a PR is still a little open. From my viewpoint, I don’t keep track of PRs on GitHub (:grimacing:) so I think if we’re looking for a more formal answer to ‘what can I do to chase up a PR review for core or something #official’ I think opening a #dev topic here on meta would be a good way to get it some extra attention. Feel free to @JammyDodger me and I’ll do my best to hound people and get it reviewed (or at least looked at). :slight_smile:

[image] G Ann Campbell: Is there a typical timeline for plugin PR review? No, not really! Though it’s helpful if you post on Meta about it (I’ll take a look within the next day or two in this case).

We’ve got one waiting for review too: [image] Putting a button into Chat for Jitsi calls Feature We’ve got a PR for this at the moment: https://github.com/discourse/discourse-jitsi/pull/22 I wasn’t sure how to get someone’s attention on it without @mentioning / pestering

[image] Nathan Kershaw: We’ve got one waiting for review too: I’ll pull someone’s sleeve for you :slight_smile:

I’ve just merged this. :tada: Thanks!

What's the process to get a theme-component PR reviewed?

Development

chapoi February 27, 2024, 7:34am 7

I’ll pull someone’s sleeve for you

Topic		Replies	Views
What is the turn around time for pull request? Development rest-api	2	310	August 24, 2023
Requesting new features for Discourse Contributing how-to	0	10195	September 7, 2015
When PRs are merged? Development	2	477	July 8, 2022
How should participants manage third-party plugin reports on Meta Site feedback	3	209	April 25, 2025
Recommended approach for production discourse using PR (not merged) Product Support	15	407	February 21, 2025

What's the process to get a theme-component PR reviewed?

Related topics