Just got an email from Maxmind: As of Wednesday, May 1, 2024, we will use R2 presigned URLs for all database downloads in order to increase the security and reliability of our services. Does anyone know whether this affects Discourse’s Maxmind usage?

Good point! Based on this article GeoIP Release Notes - 2024 Archive GeoNames monthly diff report December 2024 December 19, 2024 GeoNames monthly diff report (December 2024) GeoIP and GeoLite databases incorporate GeoNames geographical data, which is made available under the Creative Commons Attribution 4.0... It would seem that a direct link (what Discourse uses) will be fine as it is. This means it will be automatically redirected to their new URLs. So far, so good. However, from what I see in the code, it doesn’t follow redirection: This will likely fail. You would need to update the URL or allow redirection to fix this. lib/discourse_ip_info.rb main if license_key.blank? STDERR.puts "MaxMind IP database download requires an account ID and a license key" STDERR.puts "Please set DISCOURSE_MAXMIND_ACCOUNT_ID and DISCOURSE_MAXMIND_LICENSE_KEY. See https://meta.discourse.org/t/configure-maxmind-for-reverse-ip-lookups/173941 for more details." return end account_id = GlobalSetting.maxmind_account_id if account_id.present? extra_headers[ "Authorization"

[תמונה] Arkshine: However, from what I see in the code, it doesn’t follow redirection: This will likely fail. It does. [תמונה] Fail to download maxmind db with valid key & can download the DB from inside container Bug Does it work better with follow_redirect: true? As per a recent change, MaxMind changed their URL to download, but you can keep the original one as long you allow redirection. https://github.com/discourse/discourse/pull/26333

I wonder whether they recently started using redirects before implementing the presigned URLs.

I just know that changing the code to allow redirects makes it work.

Well, it was a single word, and I’d already been hacking at the code on a live site, so it wasn’t that hard. Looks like all of the automated tests passed. . .

Oh, I’d been thinking that I would have to remember how to run all the tests locally, and I’ve reinstalled since the last time I did that so I was pretty sure that would be a rabbit hole of finding and installing dependencies… Just let the automation take care of it is smart. :smiling_face:

Maxmind R2 כתובות URL חתומות מראש

תמיכה התקנה

mcdanlj (Michael K Johnson) 23 במרץ,‏ 2024,‏ 1:40pm 9

I was about to start looking to see whether there were any tests that would fail with that change, and you beat me to it!

נושא		תגובות	צפיות
Fail to download maxmind db with valid key & can download the DB from inside container Bug maxmind	15	1308	25 באפריל,‏ 2024
MaxMind 401 error -- have license key, can't download Self-hosting maxmind	7	614	8 בדצמבר,‏ 2025
GeoLite2 on the MaxmindDB site Self-hosting maxmind	4	472	17 ביוני,‏ 2024
Upgrade / Rebuilds Fail due to MaxMind DB EOL Self-hosting maxmind	14	8990	5 בפברואר,‏ 2020
Setting DISCOURSE_MAXMIND_LICENSE_KEY breaks docker image/container build Self-hosting maxmind	22	1810	16 במאי,‏ 2024

Maxmind R2 כתובות URL חתומות מראש

נושאים קשורים