Brand Header links and icons settings now Object setting type

tgxworld · April 26, 2024, 8:38am

Oops sorry about that. Looks like there is a bug in the migration which will be fixed in

github.com/discourse/discourse-brand-header

FIX: Make `links` and `icons` setting migration more resilient (#39)

main ← make_migration_more_resistant_to_invalid_formats

opened 02:53AM - 25 Apr 24 UTC

tgxworld

+77 -40

This commit updates the migrations to assume that the old setting value may be …invalid so that we don't end up with a new setting which fails the objects schema validation. This is a follow up to 7e304e0a12115c6596fc64ff173368cba1a28e7b which added migrations for the `links` and `icons` settings. We have gotten reports of errors happening with the migrations because the value of the old setting before migration did not follow the "informal" format required previously. Since there was nothing enforcing the format for the value previously, we need to assume the worst possible cases in our migrations.

Topic		Replies	Views
"An empty string is not a valid JSON string" when updating theme component Bug brand-header , fixed	2	315	August 1, 2024
Why are custom header links 'overridden'? Bug custom-header-links	17	1153	February 7, 2024
Custom Header Links (icons) Theme component official , custom-header-icons	117	34154	August 4, 2025
"An empty string is not a valid JSON string" when updating theme component #2 Bug custom-header-links , fixed	1	171	August 26, 2024
Icon type theme setting in objects type settings Feature	1	152	September 6, 2026

Brand Header links and icons settings now Object setting type

Related topics