Composer preview side shows the control buttons under the uploaded videos

AI-generated summary

The Composer preview side is showing control buttons under uploaded videos. Don reported this issue and provided screenshots. Initially, awesomerobot couldn’t reproduce the issue, but after Don uploaded a sample video, it was discovered that the issue only occurs with short videos. Further investigation revealed that the video file name containing dimensions was the cause of the problem, as it gets picked up by a function meant for images awesomerobot. awesomerobot has now prepared a PR to fix this issue: https://github.com/discourse/discourse/pull/28349.

Hello :wave:

These buttons are not active but appears under videos too.

Thanks :slight_smile:

3 Likes

I can’t reproduce the issue, is this a specific filetype perhaps? I’ve tried MP4 and WebM with no luck :thinking:

3 Likes

Hello :wave: Here is a sample video. It’s an MP4 video. I still see the buttons there…

Oh, Now I tried to upload a longer video and it seems it’s only appears to the short few sec one… :thinking:

2 Likes

Hmm now just tried on more videos. Screen records etc. and seems only that video affects now on my side, strange. Probably it’s a result of some converting. But even then it’s not normal. :thinking:

2 Likes

ah ha, this is kind of silly… but it’s because the video file name contains dimensions, this gets picked up by a function that is meant to append metadata to an image:

and this metadata is used to determine if the controls should appear

3 Likes

Indeed :hushed_face: Nice catch, I would never have realized that :sweat_smile:


![SampleVideo1mb|video](upload://7cZrskeouBoDXn3EruQR8mFS3gN.mp4)


![SampleVideo_1280x720_1mb|video](upload://7cZrskeouBoDXn3EruQR8mFS3gN.mp4)

1 Like

I’ve got a PR ready that will fix this soon:

https://github.com/discourse/discourse/pull/28349

6 Likes