Users Complaining About Losing Points

selase · December 30, 2024, 7:04pm

Leaving the default period as All Time should work just fine. All Time here is intended to be within the bounds of the leaderboard’s from/to dates, if set.

However, there appears to be a bug where filtering the leaderboard by certain periods produces incorrect results. The score_period_condition implementation doesn’t properly account for the leaderboard’s From/To dates and conflicts with the main leaderboard bounds check.

github.com/discourse/discourse-gamification

lib/discourse_gamification/leaderboard_cached_view.rb

03ea20da0


      
          def score_period_condtion(period)
            date =
              case period
              when "yearly"
                "CURRENT_DATE - INTERVAL '1 year'"
              when "monthly"
                "CURRENT_DATE - INTERVAL '1 month'"
              when "quarterly"
                "CURRENT_DATE - INTERVAL '3 month'"
              when "weekly"
                "CURRENT_DATE - INTERVAL '1 week'"
              when "daily"
                "CURRENT_DATE - INTERVAL '1 day'"
              else
                nil
              end
          
            date ? "AND gs.date >= #{date}" : ""
          end

github.com/discourse/discourse-gamification

lib/discourse_gamification/leaderboard_cached_view.rb

03ea20da0


      
          WHERE
            (
              -- Leaderboard with both "to/from" dates
              -- Only scores created between specified dates
              (
                lb.from_date IS NOT NULL
                AND lb.to_date IS NOT NULL
                AND gs.date BETWEEN lb.from_date AND lb.to_date
              )
              OR
              -- Leaderboard without "from/to" dates. All scores
              (lb.from_date IS NULL AND lb.to_date IS NULL)
              OR
              -- Leaderboard with just "from" date
              -- Only scores created starting from the specified date
              (
                lb.from_date IS NOT NULL
                AND lb.to_date IS NULL
                AND gs.date >= lb.from_date
              )

This file has been truncated. show original

I’m looking into this, a fix should be ready soon.

Topic		Replies	Views
Gamification leaderboard pagination doesn't respect the selected date period Bug gamification	1	624	January 3, 2023
Setting a leaderboard date range should lock the default period Feature gamification	4	652	January 22, 2025
Gamification period selector constraints UX gamification	1	404	March 9, 2023
Leaderboard doesn't show score for recent periods Product Support gamification	4	452	December 15, 2022
How to create a new leaderboard for a specific month? Product Support gamification	2	613	January 12, 2023

Users Complaining About Losing Points

Related topics