A bug was reported where posts in the review queue remain claimed after a user cancels the ‘Revise post’ action, preventing unclaiming. T_Disco highlighted that the post should return to an unclaimed state upon cancellation. pento confirmed a fix was merged to address this, ensuring unclaiming when cancelling. Banson asked if automatic claiming still occurs when reviewable_claiming is disabled, and pento explained that automatic claiming happens during multi-step moderation actions to prevent conflicts, with automatic unclaiming upon completion or cancellation. T_Disco reported a new issue where claiming/unclaiming one post affects others in the queue, and pento acknowledged a related bug with a fix in progress. Banson expressed hope that the fix would resolve lingering claims after resolving reviewable items.
Select ‘Revise post’ for a pending queued post (that isn’t claimed), don’t select ‘Send PM’ but cancel instead. The text now says ‘You’ve claimed this item and can review it.’ and no x button is next to the text so can’t be unclaimed.
Also, shouldn’t the post return to being unclaimed if prior to selecting ‘Revise post’ the post wasn’t claimed and you’ve opted to cancel when on ‘Revise post’?
Installed version: 3.5.0.beta7-dev (1f2efa7954)
Thanks for the bug report, @T_Disco! I’ve just merged a fix for it:
https://github.com/discourse/discourse/pull/33377
For any reviewable items that are stuck as claimed after you upgrade, you’ll be able to unclaim them by opening the Revise Post dialog, then cancelling out of it.
In our site, Discourse.SiteSettings.reviewable_claiming is set to False (so the frontend does not show any claim/unclaim button). However, when I click ‘Revise post’, the whole topic is automatically claimed by me. In such case, can the topic still be able to be unclaimed when your MR is merged and takes effect?
Event when reviewable_claiming is set to false, the automatic claiming happens when performing a moderation action that requires a multiple steps. This helps to address a problem we were seeing where multiple moderators would work simultaneously on the same reviewable item: by automatically claiming it when the first moderator starts editing, revising, or performing other complex moderation actions, subsequent moderators wouldn’t waste time working on the same one.
Any automatically claimed reviewable should be automatically unclaimed when you either finish moderating the reviewable, or cancel out of process.
Hi @pento,
Thanks for the fix. I’m not sure if this is related to the fix or not but now when on the review queue if I claim/unclaim a post it also claims/unclaims the other posts in the queue.
Installed: 3.5.0.beta8-dev (b20d6792bf)
Thanks for the extra report, @T_Disco! I haven’t been able to reproduce this issue, though I did run into a related bug that I’ve just merged a fix for:
https://github.com/discourse/discourse/pull/33405
Could you see if you can still reproduce it, and let me know specific steps to make it happen?
Thanks @pento for explaining. Previously the automatically-claimed topic stays claimed even when I resolve all its current reviewble items, so all its future flags can only be responded by me, which is annoying. Should I expect the PR fix this? 
This topic was automatically closed after 3 days. New replies are no longer allowed.
