Migrating settings should take GlobalSettings into account

I guess in this case, in future we should look at DISCOURSE_... in Env during these migrations.

@ted I guess it is worth following up retroactively cause it will establish the pattern going forward.

I am not sure if GlobalSetting is loaded or is something we want to lean on, but taking a peak at

ENV['DISCOURSE_AUTOMATIC_BACKUPS_ENABLED'] and having it win over the setting in the DB is probably wise.

@tgxworld / @ted maybe we should add a “migration helper” for this?

Eg:

MigrationHelper.get_setting('abc')
MigrationHelper.set_setting('abc', '123') 
3 Likes