Merged topics are no longer being bumped

christo · 23 oktober 2025 om 16:18

Here’s the PR to fix this issue. I’ll update again once it’s approved and merged in.

github.com/discourse/discourse

FIX: Moving first post sequentially doesn't bump the destination topic

main ← fix/move-newer-post-should-bump

merged 12:53PM - 24 Oct 25 UTC

nullchristo

+117 -19

Fixes a bug I introduced in #35373. Reported on Meta /t/386078 The intention …there was to make sure that when merging a first post from one topic which is older than the latest post in the destination topic, we shouldn't bump the destination topic. Previous to that, we were bumping the destination topic to the date of the moved post, which sometimes pushed the bumped_at timestamp back in time. Looks like that also broke the case where the moved first post is more recent than the latest post in the destination topic, because the logic for updating the bumped_at date based on the most recent merged post (in `update_last_post_stats`) wasn't considering moved posts which were the first post of their original topic because the `id` of that post has changed. This should fix both cases. Now if any post moved (including a first post) is newer than the latest post in the destination topic, the destination topic should be bumped. Post timings should still be respected. Adds test cases for chronological and sequential moves of first posts which become the newest post in the destination topic, and updates a test to make sure I didn't break post timings.

Topic		Antwoorden	Weergaven
Moving posts into an existing topic doesn't keep chronology Feature completed	44	10276	14 juni 2023
It's very surprising for "merge topics chronologically" to replace the first post of the target existing topic! Feature	6	473	10 juli 2023
Unable to merge Posts/Topics with Banner Topic Bug	1	212	24 januari 2024
Move later post to another topic: shouldn't it bump the topic up the list? Feature	17	1311	22 februari 2018
Topic unlisted to all users including admins after merging topics Support	3	109	28 juni 2025

Merged topics are no longer being bumped

Gerelateerde topics