Installing a new theme permanently deletes custom color palettes

kris.kotlarek · 3 בנובמבר,‏ 2025,‏ 6:10am

Thank you for reporting this bug. It was fixed in this PR:

github.com/discourse/discourse

FIX: Prevent deletion of custom color palettes when installing themes

main ← incorrectly-delete-custom-palettes

merged 06:09AM - 03 Nov 25 UTC

KrisKotlarek

+18 -1

When installing a new theme, custom color palettes (with theme_id = nil) were be…ing incorrectly deleted. This occurred because the theme installation process called `update_theme_color_schemes` before the new theme was persisted to the database. Since the theme's ID was nil, the query `ColorScheme.unscoped.where(theme_id: nil)` would match ALL custom color schemes, causing them to be deleted during the cleanup phase. Bug introduced in this PR - https://github.com/discourse/discourse/pull/34722

נושא		תגובות	צפיות
Update / re-download the default theme and color palette Support	7	630	6 באפריל,‏ 2023
New forum instance. Unable to change colors Support	12	484	14 באפריל,‏ 2024
Changing Color Palette - Light (default) Support	6	541	26 באוגוסט,‏ 2023
I can no longer change the color palette Support	4	397	9 באוגוסט,‏ 2023
Color palette settings are not being reflected Dev	7	145	26 בינואר,‏ 2025

Installing a new theme permanently deletes custom color palettes

נושאים קשורים