I was looking at the #gifs TC yesterday, and I noticed this block of code: javascripts/discourse/components/modal/gif.gjs 910bd8b73 let markup = [ "\n", `![${content.title}|${content.width}x${content.height}](${content.original})`, "\n", ].join(""); if (this.args.model?.customPickHandler) { this.args.model.customPickHandler(markup); } else { this.appEvents.trigger("composer:insert-text", markup); } Where it uses the appEvents service. The thing is, why can’t toolbarEvent be passed in at the action? javascripts/discourse/initializers/gif-integration.js 910bd8b73 api.onToolbarCreate((toolbar) => { if (toolbar.context.composerEvents) { toolbar.addButton({ title: themePrefix("gif.composer_title"), id: "gif_button", group: "extras", icon: "discourse-gifs-gif", condition: () => api.container.lookup("service:site").desktopView, action: () => { const modal = api.container.lookup("service:modal"); modal.show(GifModal); I’ve tried it and it seems to work. Was there a reason why that was not used? Considering it uses TextManipulation under the hood, there seems to be a insertText method. Just curious. Thanks.

I think discourse-gifs does it like this because the Modal is also launched from outside the toolbar: javascripts/discourse/components/gif-button.gjs 1fa66e5fb showGifModal() { this.modal.show(GifModal); } If your new thing is entirely toolbar-based, then I agree toolbarEvents is the cleaner way to go :ok_hand:

Digging a bit further, I found this line: frontend/discourse/app/components/d-editor.gjs d440592f8 setupEvents() { const textManipulation = this.textManipulation; if (this.composerEvents) { this.appEvents.on( "composer:insert-block", textManipulation, "insertBlock" ); this.appEvents.on("composer:insert-text", textManipulation, "insertText"); this.appEvents.on( "composer:replace-text", textManipulation, "replaceText" ); this.appEvents.on( "composer:apply-surround", textManipulation, "applySurroundSelection" ); So… the app event still performs the same as textManipulation? What would be the added advantage in the TC?

Anyone has any ideas? I’m considering the appEvent versus toolbarEvent, and knowing the differences (if any) would be helpful.

Ah, that’s it. Thanks for clarifying, I’ll go ahead with toolbarEvent then.

Discourse GIFs TC 添加 GIF 时为何不使用 toolbarEvent？

开发

NateDhaliwal (Nate Dhaliwal) 2025 年11 月 6 日 14:09 4

有人有什么想法吗？我正在考虑 event 和 toolbarEvent，了解（如果有的话）它们的区别将很有帮助。

话题		回复	浏览量
Plugin: access to toolbarEvent from modal Development	5	875	2025 年1 月 21 日
AppEvents Triggers Reference Developer Guides	0	608	2024 年11 月 26 日
Discourse Gifs Theme component official , gifs	110	33829	2026 年6 月 9 日
How to customize the composer toolbar? Feature composer	13	999	2026 年9 月 22 日
Need help to getSelected and replace from Toolbarevent Development	5	1159	2022 年5 月 15 日

Discourse GIFs TC 添加 GIF 时为何不使用 toolbarEvent？

相关话题