I was looking at the #gifs TC yesterday, and I noticed this block of code: javascripts/discourse/components/modal/gif.gjs 910bd8b73 let markup = [ "\n", `![${content.title}|${content.width}x${content.height}](${content.original})`, "\n", ].join(""); if (this.args.model?.customPickHandler) { this.args.model.customPickHandler(markup); } else { this.appEvents.trigger("composer:insert-text", markup); } Where it uses the appEvents service. The thing is, why can’t toolbarEvent be passed in at the action? javascripts/discourse/initializers/gif-integration.js 910bd8b73 api.onToolbarCreate((toolbar) => { if (toolbar.context.composerEvents) { toolbar.addButton({ title: themePrefix("gif.composer_title"), id: "gif_button", group: "extras", icon: "discourse-gifs-gif", condition: () => api.container.lookup("service:site").desktopView, action: () => { const modal = api.container.lookup("service:modal"); modal.show(GifModal); I’ve tried it and it seems to work. Was there a reason why that was not used? Considering it uses TextManipulation under the hood, there seems to be a insertText method. Just curious. Thanks.

I think discourse-gifs does it like this because the Modal is also launched from outside the toolbar: javascripts/discourse/components/gif-button.gjs 1fa66e5fb showGifModal() { this.modal.show(GifModal); } If your new thing is entirely toolbar-based, then I agree toolbarEvents is the cleaner way to go :ok_hand:

Digging a bit further, I found this line: frontend/discourse/app/components/d-editor.gjs d440592f8 setupEvents() { const textManipulation = this.textManipulation; if (this.composerEvents) { this.appEvents.on( "composer:insert-block", textManipulation, "insertBlock" ); this.appEvents.on("composer:insert-text", textManipulation, "insertText"); this.appEvents.on( "composer:replace-text", textManipulation, "replaceText" ); this.appEvents.on( "composer:apply-surround", textManipulation, "applySurroundSelection" ); So… the app event still performs the same as textManipulation? What would be the added advantage in the TC?

Anyone has any ideas? I’m considering the appEvent versus toolbarEvent, and knowing the differences (if any) would be helpful.

Why doesn't Discourse GIFs TC use toolbarEvent instead of app event when adding the GIF?

Development

NateDhaliwal (Nate Dhaliwal) November 7, 2025, 2:30am 7

Ah, that’s it. Thanks for clarifying, I’ll go ahead with toolbarEvent then.

Topic		Replies	Views
Plugin: access to toolbarEvent from modal Development	5	875	January 21, 2025
AppEvents Triggers Reference Developer Guides	0	610	November 26, 2024
Discourse Gifs Theme component official , gifs	110	33856	June 9, 2026
How to customize the composer toolbar? Feature composer	13	1000	September 22, 2026
Need help to getSelected and replace from Toolbarevent Development	5	1163	May 15, 2022

Why doesn't Discourse GIFs TC use toolbarEvent instead of app event when adding the GIF?

Related topics