Embedded media post allowed groups conflicts with post moderation workflow: unhide! fails with ActiveRecord::RecordInvalid

@kris.kotlarek how do you feel about

https://github.com/discourse/discourse/pull/36512

I think it is safe, specifically cause there is a callsite that still expects validation: PostRevisor#remove_flags_and_unhide_post so the extra param allows us to give it a bit more safety.

That said, these code paths are very complicated… so it is worth a careful review.

2 Likes