Assign dialog behavior changed overnight to require mousing

zogstrip · 10 בדצמבר,‏ 2025,‏ 3:20pm

Modals are really hard to get right

Hopefully that fixes it and doesn’t introduce any regressions

github.com/discourse/discourse

FIX: Allow Enter key to work inside select-kit within modals

main ← fix-pressing-enter-within-select-kit-within-a-modal-inception-style

opened 03:19PM - 10 Dec 25 UTC

ZogStriP

+58 -2

When selecting an item in a select-kit dropdown (e.g., the assignee chooser in t…he assign modal), pressing Enter would close the modal without completing the selection. This was caused by commit 1d2ae5159b which added `{ capture: true }` to the modal's keydown listener to prevent keypresses from leaking outside modals. However, this caused the modal to intercept Enter before the select-kit could process it, triggering the primary button click prematurely. Add a check for `.select-kit` elements in `shouldTriggerClickOnEnter()` so the modal defers to select-kit's own Enter key handling. Ref - meta/t/390910

נושא		תגובות	צפיות
Key combo to submit assignment dialog, please Feature assign	16	882	12 ביולי,‏ 2025
Can no longer submit from assignment comment :cry: Bug assign	2	226	25 באפריל,‏ 2024
Focus in 'Edit Assignment' dialog UX assign	2	403	28 בספטמבר,‏ 2023
Application-level keyboard shortcuts should be disabled when a modal is open Bug keyboard-shortcuts	2	764	18 בינואר,‏ 2018
Assignment dialog never gives me the chance to leave a note Feature assign	12	597	10 ביוני,‏ 2022

Assign dialog behavior changed overnight to require mousing

נושאים קשורים