"Attach a file" option unresponsive in desktop Safari

zogstrip · 29 januari 2026 om 09:49

Unfortunately the fix broke the “options” in that list that opened a modal…

github.com/discourse/discourse

FIX: Modal-based chat composer buttons not working on mobile

main ← fix/chat-composer-dropdown-mobile-modals

merged 10:20AM - 29 Jan 26 UTC

ZogStriP

+10 -3

Commit 9cbb0c3da3 fixed Safari file uploads by removing async/await from the but…ton click handler, but this introduced a regression: modal-based buttons (like "Insert date/time") stopped working on mobile. The issue is a race condition where the modal tries to open while the dropdown menu modal is still closing, causing the new modal to be dismissed immediately. This fix introduces a `synchronous` property for chat composer buttons: - `synchronous: true` - action runs immediately without awaiting the menu close (required for file inputs on Safari) - `synchronous: false` (default) - awaits menu close before running action (required for modal-based buttons) The upload button is marked with `synchronous: true` to preserve the Safari fix, while all other buttons use the default async behavior.

Topic		Antwoorden	Weergaven
Cannot upload images with Safari Bug	32	2810	24 mei 2023
New chat button is squished UX completed , chat	3	466	4 december 2023
Image uploads not working on MacOS Safari 13 since Uppy Bug	4	962	27 december 2021
[PAID] Discourse Chat Bug Fixes + Enhancements Marketplace	14	474	13 juni 2025
Edit button is not clickable in Safari Bug	3	645	28 december 2018

"Attach a file" option unresponsive in desktop Safari

Gerelateerde topics