Display full name not username when attributing quote in RTE

zogstrip · 26 februari 2026 om 10:08

Great work @Moin root causing this one

It made it 100x times easier to fix

github.com/discourse/discourse

FIX: Preserve display name in quotes when using the rich text editor (#38078)

main ← fix/rte-quote-display-name

merged 08:04PM - 26 Feb 26 UTC

ZogStriP

+45 -18

When `display_name_on_posts` is enabled and `prioritize_username_in_ux` is disab…led, quoting a post in markdown mode correctly attributes the quote to the user's full name (e.g. `[quote="Robin Ward, post:1, topic:2, username:eviltrout"]`). However, the rich text editor lost the display name during the markdown→ProseMirror→markdown round-trip, falling back to just the username. The ProseMirror quote node only stored `username` in its attributes. When BBCode with a `username:` param was parsed, the display name was discarded. On serialization, only the username survived. This commit: - Adds a `displayName` attribute to the ProseMirror quote node spec - Emits `data-display-name` on the markdown-it aside token so the ProseMirror parser can pick it up - Updates the serializer to output the display name and `username:` param when present - Fixes a latent issue where `displayName` remained as an array instead of being joined into a string when the name contains no commas https://meta.discourse.org/t/397049/12

Topic		Antwoorden	Weergaven
Quoting broken when name matches username Bug	21	1841	27 april 2022
"display name on posts" should apply to quotes, too Feature	2	447	25 februari 2026
Display full name not username when attributing quote or reply Bug	4	1121	28 april 2022
Why only some replies show fullname while others not? Support	8	679	21 juli 2022
Can a Theme have a quote display real name instead of username? Feature	2	682	22 mei 2020

Display full name not username when attributing quote in RTE

Gerelateerde topics