Required: true not enforced for upload field in form templates

zogstrip · 23 maart 2026 om 18:23

Nice catch It should be fixed by

github.com/discourse/discourse

FIX: Enforce `required` validation on form template upload field (#38799)

main ← fix/form-template-upload-required-validation

merged 01:07PM - 24 Mar 26 UTC

ZogStriP

+100 -2

The `required: true` validation on upload fields in form templates was not being… enforced. Users could submit forms without attaching any file even when the upload field was marked as required. The root cause is that the upload field used a `<input type="hidden">` to store its value. Hidden inputs are excluded from the browser's constraint validation API — `form.checkValidity()` skips them entirely. All other form template field types (input, textarea, dropdown, etc.) use visible form elements where the native `required` attribute works. The fix changes the hidden input to a visually-hidden `<input type="text">` so that native constraint validation applies. The input is positioned off-screen via CSS and made non-interactive with `tabindex="-1"` and `aria-hidden="true"`. It is also placed as the last child in the container so the validation error message (inserted via `insertAdjacentElement("afterend")`) renders in a visible location. A synthetic `input` event is dispatched after upload completion so the validation error clears once a file is attached. https://meta.discourse.org/t/398972

Topic		Antwoorden	Weergaven
'Upload Fails' error when using form templates Bug form-templates	9	548	13 november 2023
Hidden upload field is not hidden UX fixed	2	72	6 augustus 2025
Checkbox Validation: No Error Message Shown When Required Support form-templates	0	52	27 juni 2025
Topic template cannot allow user to upload media, and the 3 lines at the top do nothing Support form-templates	3	331	24 maart 2024
Creating form templates Site Management form-templates	1	182	11 maart 2026

Required: true not enforced for upload field in form templates

Gerelateerde topics