Category experts plugin crashes on merging users

zogstrip · 2 april 2026 om 15:41

Thanks for the report @RGJ

Will be fixed by

github.com/discourse/discourse-category-experts

FIX: Use `save_custom_fields` instead of `save!` when only custom fie… (#230)

main ← fix/save-custom-fields-during-owner-change

merged 04:25PM - 02 Apr 26 UTC

ZogStriP

+23 -8

…lds changed During user merges, `PostOwnerChanger` reassigns all post types …including small action posts which have `raw: nil` by design. The core `set_owner` method handles this correctly via `skip_validations: true`, but the plugin's `post_owner_changed` handler and `PostHandler` methods were calling `save!` after only modifying custom fields. This triggered full AR validations on the post body, raising `ActiveRecord::RecordInvalid` for posts with content that doesn't pass current validation rules. Replace all `save!` calls with `save_custom_fields` in places where only custom fields are being modified — 8 occurrences across `plugin.rb` and `PostHandler` (`mark_post_for_approval`, `mark_post_as_approved`, `mark_topic_as_question`, `correct_topic_custom_fields_after_removal`, `correct_topic_custom_fields_after_addition`, `handle_topic_category_change`). https://meta.discourse.org/t/399785

Topic		Antwoorden	Weergaven
Merge users not possible from UI or CLI Support merge-user	2	481	14 mei 2025
User merge failed, corrupted database entries due to third party plugin Support merge-user	32	2614	5 november 2020
Issue merging user accounts, web interace and rake console Support merge-user	10	416	14 mei 2025
Rake users:merge on former admin account throws error Support merge-user	15	917	14 maart 2019
`NoMethodError in TopicsController#show` error after merging topics Bug calendar-and-event , pr-welcome	3	110	27 juni 2025

Category experts plugin crashes on merging users

Gerelateerde topics