"do you want to discard your post ?"

zogstrip · 8 april 2026 om 09:30

Thanks for the report @RGJ It’ll be fixed by

github.com/discourse/discourse

FIX: use editing-specific text for composer discard and fix false dirty state (#39149)

main ← fix/composer-discard-editing-context

merged 09:07PM - 14 Apr 26 UTC

ZogStriP

+136 -10

When editing a post, the composer's cancel button said "Discard" and the confirm…ation modal said "Do you want to discard your post?" — which sounds like you're deleting the post itself. Additionally, the modal appeared even when no edits were made. **BEFORE** | Scenario | Cancel button | Modal message | Modal OK | |-----------------|---------------|------------------------------------|----------| | Create topic | Discard | Do you want to discard your post? | Discard | | Reply | Discard | Do you want to discard your post? | Discard | | Edit | Discard | Do you want to discard your post? | Discard | | Private message | Discard | Do you want to discard your post? | Discard | \+ 🐛 bug: edit modal appears even with no changes **AFTER** | Scenario | Cancel button | Modal message | Modal OK | |-----------------|---------------|---------------------------------------|-----------------| | Create topic | Discard | Do you want to discard your post? | Discard | | Reply | Discard | Do you want to discard your post? | Discard | | Edit | Cancel edit | Do you want to discard your changes? | Discard changes | | Private message | Discard | Do you want to discard your post? | Discard | The false dirty state had two causes: 1. `anyDirty` included `titleDirty` even when editing non-first posts where the title isn't editable. The title was set to the topic title during the `serialize(_edit_topic_serializer)` call but `originalTitle` was only set for first posts, making `titleDirty` always true. Fixed by scoping `titleDirty` in `anyDirty` to only apply when `canEditTitle` is true, and by always setting `originalTitle` when loading a post for editing. 2. `hasMetaData` had inverted logic — `isEmpty(Object.keys(this.metaData))` returned true when metadata was empty, not when it had keys. https://meta.discourse.org/t/399942

Topic		Antwoorden	Weergaven
Suggestion to make it clearer that discarding an edited post discards the draft, not the original post UX composer	0	399	4 januari 2023
编辑器删除图标不一致 UX	1	37	27 april 2026
Possibly scary warning while abandoning a post edit UX	6	1106	30 oktober 2019
Trash icon to discard an edit doesn't seem quite right UX	5	849	29 maart 2018
Clicking "Keep Editing" button doesn't do anything Bug	7	595	22 april 2023

"do you want to discard your post ?"

Gerelateerde topics