Inconsistent permission to use the same tag in the same category

zogstrip · 15 באפריל,‏ 2026,‏ 8:31pm

Ahah, my bad The feature needed to be a tad bit “smarter” when it comes to limits

github.com/discourse/discourse

FIX: don't mislabel allowed tags as disabled in composer tag search (#39300)

main ← fix-disabled-tags-mislabeled

merged 07:01AM - 16 Apr 26 UTC

ZogStriP

+54 -6

When searching tags in the composer, `filter_allowed_tags` applies a LIMIT (`max…_tag_search_results`, default 5). If more allowed tags match the query than fit under the limit, the overflow is silently dropped. `append_disabled_tags` then ran a naive substring query for visible tags matching the term, assumed any tag not in the allowed list must be excluded by filter rules, and asked `explain_exclusion` to fabricate a reason. Allowed-but-cut-off tags leaked into the disabled list and showed the vague fallback "\"X\" cannot be used in this category". Because `filter_allowed_tags` orders by term (`DISTINCT ON (lower(name) = lower(term), ...)`), the same tag could appear allowed under one search term (prefix match, ranks high, fits in the limit) and disabled under another (mid-string match, ranks lower, gets cut off) — producing inconsistent verdicts for the same tag in the same category. Before labeling any tag as disabled or forbidden, re-run `filter_allowed_tags` scoped to the candidate names (no limit) and drop any that come back allowed. Extracted to `reject_allowed_tags` so both `append_disabled_tags` and `detect_forbidden_tag` go through the same verification. The probe is skipped when the allowed result didn't saturate its limit, since no cutoff is possible in that case. https://meta.discourse.org/t/400696

נושא		תגובות	צפיות
Tag "Search or create" text is displayed when a category has restricted tags UX tags	1	554	31 ביולי,‏ 2023
Restrict tags to specific categories Feature completed	19	5185	8 באוגוסט,‏ 2023
Limiting tags to categories not working as expected Bug tags	9	815	24 במאי,‏ 2023
Can't use certain tags to tag topics anymore Bug	16	3539	19 באוגוסט,‏ 2016
Restricted tags/tag groups not appearing in autocomplete Bug hashtag-autocomplete	3	524	24 בדצמבר,‏ 2022

Inconsistent permission to use the same tag in the same category

נושאים קשורים