Cannot search for icon by name in custom sidebar section configuration modal

zogstrip · 20 באפריל,‏ 2026,‏ 9:57am

Nice one @Lilly

Looks like a recent-ish regression, which should be fixed by

github.com/discourse/discourse

FIX: Allow typing inside float-kit menus rendered from within a modal (#39370)

main ← fix-icon-picker-filter-in-modal

merged 01:08PM - 21 Apr 26 UTC

ZogStriP

+43 -5

`DModal` listens for `keydown` on `documentElement` in the capture phase and can…cels events whose `activeElement` is not inside the modal wrapper, to prevent keyboard shortcuts from leaking to the page behind the modal. Since `DIconGridPicker` replaced the select-kit `IconPicker` in the custom sidebar section modal (#38943), the picker's filter input renders inside the `#d-menu-portal-outlet` portal — outside the modal DOM — so every keystroke was cancelled and typing silently failed. Allow keydown through when `activeElement` is inside a float-kit portal (`.fk-d-menu`, `.fk-d-menu-modal`, `.fk-d-tooltip`), which covers any menu/tooltip opened from within a modal without weakening the leak guard for elements actually behind the modal. Also adds a system spec that catches this with real keyboard typing (the existing `icon_picker.filter` helper used `fill_in` + clicked the target icon which was already visible without filtering, so the bug slipped past the suite). https://meta.discourse.org/t/400945

(cc @saquetim)

נושא		תגובות	צפיות
Search Icon can appear outside drop-downs Bug	4	594	22 במאי,‏ 2018
Preactivate the search field of the GIF search UX gifs , chat	8	117	11 בינואר,‏ 2025
How to choose icons for links in custom section UX sidebar	9	460	5 במרץ,‏ 2026
Advanced Header Search Theme component official , header-search	49	6348	27 באוגוסט,‏ 2025
Making a search icon with a theme Support	7	991	4 באוגוסט,‏ 2022

Cannot search for icon by name in custom sidebar section configuration modal

נושאים קשורים