Uppercase letters in username break reachable mention check in composer

zogstrip · 13 במאי,‏ 2026,‏ 4:25pm

Looks like my “fix” revealed this issue for AI Agents

github.com/discourse/discourse

FIX: Suppress composer mention warning for AI bot users (#39986)

main ← fix-composer-mention-warning-ai-bots

opened 04:24PM - 13 May 26 UTC

ZogStriP

+85 -1

Mentioning an AI bot (e.g. `@Forum_Research_Assis`) in a topic the bot's User re…cord can't see — like a category restricted to a group the bot isn't part of — surfaced the "this user cannot see this mention" warning popup in the composer. The warning is misleading: AI bots reply via `PostCreator.create!(... skip_guardian: true)` (`playground.rb`), so they respond regardless of whether their User can `Guardian#can_see?` the topic. The previous case-insensitive fix (9a4cca29) exposed this latent behavior. Pre-fix, mixed-case names hit a case-sensitive hash miss in `ComposerController#mentions` and silently returned an empty `user_reasons`. Post-fix, the lookup hits correctly and the reachability check — which was always there — now fires for AI bot users that genuinely can't see the topic. Adds a `:composer_mention_user_reason` plugin modifier, applied after the standard reason is computed in `user_reason`, so plugins can clear or transform it. The AI plugin registers against the modifier and returns `nil` for any user in `DiscourseAi::AiBot::EntryPoint.all_bot_ids` (covering both AI agent users and chat-bot-enabled LLM model users). discobot and the system user are intentionally unaffected: discobot's `PostCreator.create!` does not skip the guardian, so the reachability warning remains accurate for it. https://meta.discourse.org/t/401292

נושא		תגובות	צפיות
Preview is changing casing of @ mentions Bug	1	895	15 ביוני,‏ 2015
Rich editor misses usernames with umlauts Bug composer	3	219	29 ביולי,‏ 2025
Discobot case-sensitive mentions Bug	2	615	7 במאי,‏ 2019
Highlighting current user and bots in posts UX feedback , design-experiment	3	163	19 במרץ,‏ 2026
Capitalization does not match when you open user cards using mentions Bug	12	1054	3 במאי,‏ 2022

Uppercase letters in username break reachable mention check in composer

נושאים קשורים