A recent change on Discourse main branch ( https://github.com/discourse/discourse/commit/e84d7c9f26ed ) broke our way of linting the custom plugins we’re working on. The PR/commit subject was DEV: Update bin/lint to work correctly for non-bundled plugins So I’m wondering if we’re doing something …

Thanks! I tried out the branch from your fix. It works only partially for me though, as it stops after template-lint and does not run any further checks.

I suspect it is running stylelint after ember-template-lint, but the output is empty so it’s not obvious. I just pushed a commit which adds some simple progress output, and a final summary.

I tried your updated branch, but I think the problem lies somewhere else. It’s now printing the summary, that’s nice and fine, but I think it does not look at the right files :joy: If I compare it to 146fb61e104e, it just does not detect any linting violations I insert in .scss or .js files.

I tried adding violations in scss and js files in my testing, and it seemed to work. Could you try running bin/lint --verbose plugins/my-custom-plugin, and see if the files are listed correctly in the output?

Good point about verbose! Yes, the file paths are ok and I can get it to report :tada:. However, it silently does nothing when I pass --fix. Did you change the API there?

Oh… :facepalm: I pushed another commit. Would you mind trying one more time?

Nice! Works fine for me now :tada: Sorry for the late response - was off for non-computer duties.

Great - thanks for your help! I’ve merged the PR :rocket:

Update to bin/lint breaks linting flow for non-bundled plugins

Ontwikkelaar

david (David Taylor) 4 mei 2026 om 10:18 2

Thanks for the report @klappradla. This should fix it up:

https://github.com/discourse/discourse/pull/39705

Topic		Antwoorden	Weergaven
Linting consistency Development	9	233	2 december 2025
Is there a way to lint handlebars? Development	14	2590	18 februari 2021
Theme lint fails because -- Could not find "@discourse/lint-configs/stylelint" Development	4	112	14 maart 2025
Automatically lint and format code before commits Developer Guides how-to , code	0	1557	8 november 2019
Travis tests failing due to eslint Development	7	1175	10 september 2020

Update to bin/lint breaks linting flow for non-bundled plugins

Gerelateerde topics