Disabling report descriptions causes other descriptions to be hidden

zogstrip · 15 ביוני,‏ 2026,‏ 3:17pm

Sorry about that, issue should be fixed by

github.com/discourse/discourse

FIX: Ensure each flag gets a unique `name_key` (#40899)

main ← fix-flag-name-key-uniqueness

opened 03:17PM - 15 Jun 26 UTC

ZogStriP

+123 -1

Previously, flag names with no ASCII word characters (e.g. Chinese) all normaliz…ed to the same `name_key` of `custom_`, because `set_name_key` stripped non-`\w` characters and Ruby's `\w` is ASCII-only. The flag system keys lookups by `name_key` (the `disabled_flag_types` enum, the frontend `actionByName` map), so once two flags shared a key, disabling one of them flipped `can_act` for the whole group and hid every other flag that shared it. This makes `name_key` reliably unique: - `set_name_key` falls back to `custom_flag` when the slug is empty and appends a counter (`_2`, `_3`, ...) on collision, so distinct names always produce distinct keys. It now only re-derives the key when the name actually changes, keeping it stable across other saves. - A post-deploy migration backfills existing duplicate keys and adds the unique index on `flags.name_key` that the original `create_flags` migration intended (`unique: true` is a no-op in `create_table`). https://meta.discourse.org/t/405254

נושא		תגובות	צפיות
Flag modal shows chat descriptions when you flag posts UX moderation , chat	0	168	12 באפריל,‏ 2024
Modify/add site text associated with custom moderation flags? Bug review-queue	9	208	4 בדצמבר,‏ 2024
Missing translate "enable group directory" Bug	1	995	25 בדצמבר,‏ 2016
Flag reason/s Support	4	529	10 בנובמבר,‏ 2022
Posts are hidden after a single flag Feature	83	8768	8 באוקטובר,‏ 2019

Disabling report descriptions causes other descriptions to be hidden

נושאים קשורים