禁用投票限制似乎会导致主题投票中的通知提示失效

zogstrip · 2026 年7 月 15 日 10:41

感谢 @Moin 的报告该问题将通过以下链接修复：

github.com/discourse/discourse

FIX: Show the voting notification prompt when vote limits are disabled (#41731)

main ← fix-topic-voting-notification-prompt-vote-limits

merged 12:54PM - 15 Jul 26 UTC

ZogStriP

+58 -146

When topic voting vote limits are disabled, the "Notify me about new posts" prom…pt shown after voting never appeared. That prompt is part of the menu the vote button opens, but the menu was only rendered when vote limits were enabled — with limits off the button had no menu at all, so both the notification prompt and the remove-vote action were unreachable. The fix renders the menu for any signed-in user rather than gating it on vote limits. The remaining-votes rows stay tied to limits being enabled, while remove-vote and watch-topic show whenever the user has voted. Removing a vote with limits disabled now goes through the menu, matching the behavior when limits are enabled. Reported at https://meta.discourse.org/t/disabling-vote-limits-seems-to-break-notification-prompt-in-topic-voting/407512 The second commit is follow-up housekeeping on the plugin, kept separate from the fix: removing dead code and duplication in the vote components and initializers, counting a user's votes with `COUNT` instead of loading every row on each current-user serialization, and deleting orphaned i18n keys and a route-map filename left over from the plugin's former name. ### Testing - Added a system spec covering the notification prompt appearing after voting with vote limits disabled. - Existing topic-voting system and JS specs pass; the model spec still covers the trust-level-0 lock via `reached_voting_limit?`.

话题		回复	浏览量
Hide Votes Left Theme component topic-voting	6	198	2026 年5 月 15 日
The "vote" button should be disabled when the limit is reached Bug topic-voting	2	1603	2025 年11 月 11 日
Topic Voting enabled for our #feature category! :partying_face: Site feedback topic-voting	43	1467	2026 年4 月 1 日
Discourse Topic Voting Plugin official , topic-voting , included-in-core	36	84013	2026 年6 月 5 日
False Limit of Suggestion Votes on meta.discourse.org UX topic-voting	4	140	2025 年1 月 21 日

禁用投票限制似乎会导致主题投票中的通知提示失效

相关话题